Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosave logs at the end of installation #887

Merged
merged 17 commits into from
Dec 4, 2023
Merged

Autosave logs at the end of installation #887

merged 17 commits into from
Dec 4, 2023

Conversation

mchf
Copy link
Contributor

@mchf mchf commented Nov 23, 2023

Problem

Agama should automatically store logs at the en of installation

Solution

Call "agama logs store" at the end of installation

Testing

  • Tested manually

@coveralls
Copy link

coveralls commented Nov 23, 2023

Coverage Status

coverage: 75.025% (-0.3%) from 75.35%
when pulling 60739b9 on autosave_logs
into eb64654 on master.

@mchf mchf requested a review from imobachgs November 23, 2023 09:48
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it looks good. I am just wondering why the tests are failing...

service/lib/agama/manager.rb Outdated Show resolved Hide resolved
service/lib/agama/manager.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment. Otherwise, LGTM.

service/Gemfile.lock Outdated Show resolved Hide resolved
@mchf mchf merged commit 7903c82 into master Dec 4, 2023
7 checks passed
@mchf mchf deleted the autosave_logs branch December 4, 2023 10:42
@imobachgs imobachgs mentioned this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants